[PATCH] D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 19 07:44:56 PDT 2023


Eugene.Zelenko added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp:22
+  bool operator()(const internal::BoundNodesMap &Nodes) const {
+    auto *Other = Nodes.getNode(ID).get<ValueDecl>();
+    if (!Other)
----------------
`const auto *`.


================
Comment at: clang-tools-extra/clang-tidy/readability/ReferenceToConstructedTemporaryCheck.cpp:26
+
+    auto Self = Node.get<MaterializeTemporaryExpr>();
+    if (!Self)
----------------
Ditto.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/reference-to-constructed-temporary.cpp:31
+}
+
----------------
Excessive newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146368/new/

https://reviews.llvm.org/D146368



More information about the cfe-commits mailing list