[PATCH] D134827: [clangd] Avoid recursion on UnresolvedUsingValueDecl during semantic highlighting

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

I will go ahead and merge this partial fix because it is an improvement over the current state.

@sammccall I'm still curious to know your thoughts on the approach for fixing the mutually-recursive case. Is there something more general than adding a recursion guard like this to semantic highlighting code that I'm overlooking?

> we may want a "seen decls" set (similar to `SeenTemplates` here <https://searchfox.org/llvm/rev/412141663cfcc7883c24217bcb88780e4572543b/clang-tools-extra/clangd/AST.cpp#944>) in the `kindForDecl()` recursion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134827/new/

https://reviews.llvm.org/D134827