[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

[Carlos Galvez via Phabricator via cfe-commits]

carlosgalvezp added a comment.

Looks good but I fail to understand what exactly the patch fixes, can you point me to an example in the tests? It would be easier to review if the NFC changes had been done in a separate patch.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-c-language.c:4
+// clang-format off
+typedef signed char         int8_t;     // NOLINT
+typedef short               int16_t;    // NOLINT
----------------
PiotrZSL wrote:
> those typedefs looks to be duplicated already in identifier-naming-hungarian-notation.cpp and identifier-naming-hungarian-notation-cfgfile.cpp, move them to separate header file
Next time please apply this change in a separate NFC patch, for easier review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144912/new/

https://reviews.llvm.org/D144912