[PATCH] D145843: [clangd] Add option to always insert headers with <> instead of ""

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 17 22:22:57 PDT 2023


nridge added a comment.

Thanks for the patch!

May I suggest the flag name `IncludeDelimiter`, with values `Auto` and `AlwaysBrackets` (with the default being `Auto`)? This leaves room for other styles in the future if desired.

It would mean a slight implementation change since the YAML representation would now be a string rather than a bool, but nothing too involved; you can use the existing code for parsing `IndexBlock::Background` (whose allowed values are `Build` and `Skip`) as a guide.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145843/new/

https://reviews.llvm.org/D145843



More information about the cfe-commits mailing list