[PATCH] D145639: [Coroutines] Fix premature conversion of return object

[Bruno Cardoso Lopes via Phabricator via cfe-commits]

bruno added a comment.

> @bruno, @ChuanqiXu please let us know if you have any objections, otherwise we will land the revert in ~2 hours.

No sweat, I didn't see this in time. Thanks for the reduced testcase.

> What's the resolution here? Can we revert this and continue the discussions independently?

Eager initialization breaks us, lack of RVO on matching types breaks others. Landing this + D145641 <https://reviews.llvm.org/D145641> altogether seems like the best approach.

> We can always re-land this change if the conclusion is that the approach here is the one that we want.

Once we wrap up D145641 <https://reviews.llvm.org/D145641> I'll land both, as separated commits but in the same push.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145639/new/

https://reviews.llvm.org/D145639