[PATCH] D144976: [clangd] Add provider info on symbol hover.

Viktoriia Bakalova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 17 10:30:41 PDT 2023


VitaNuo updated this revision to Diff 506132.
VitaNuo marked 15 inline comments as done.
VitaNuo added a comment.

Address review comments, simplify test. 
Take care of main file as provider handling:

- provider list [main-file,foo.h] and foo.h \#include'd - not show any providers on hover.
- provider list [foo.h,main-file] and foo.h \#include'd - "provided by foo.h".
- provider list [main-file, bar.h] and bar.h not \#include'd - not show any providers on hover.
- provider list [bar.h,main-file] and bar.h not \#include'd - "provided by bar.h".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144976/new/

https://reviews.llvm.org/D144976

Files:
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/Hover.h
  clang-tools-extra/clangd/IncludeCleaner.cpp
  clang-tools-extra/clangd/IncludeCleaner.h
  clang-tools-extra/clangd/Preamble.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp
  clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144976.506132.patch
Type: text/x-patch
Size: 14928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230317/1f27da11/attachment.bin>


More information about the cfe-commits mailing list