[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

[Younan Zhang via Phabricator via cfe-commits]

zyounan added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:60
 
+bool shouldPatchPlaceholder0(CodeCompletionResult::ResultKind ResultKind,
+                             CXCursorKind CursorKind) {
----------------
nridge wrote:
> nit: let's add a short comment to describe the function, such as:
> 
> ```
> // Determine whether the completion string should be patched
> // to replace the last placeholder with $0
> ```
Sure!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145319/new/

https://reviews.llvm.org/D145319