[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

[Dhruva Chakrabarti via Phabricator via cfe-commits]

dhruvachak marked an inline comment as done.
dhruvachak added inline comments.


================
Comment at: clang/test/OpenMP/target_map_codegen_hold.cpp:211
+// CHECK-NOUSE-I386: @llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 0, ptr @.omp_offloading.requires_reg, ptr null }]
+//.
 // CHECK-USE-PPC64LE-LABEL: define {{[^@]+}}@_Z20explicit_maps_singlei
----------------
jdoerfert wrote:
> The hash is hardcoded. I recommend removing this part and putting the old check lines in again.
@jdoerfert Thanks for the suggestion. It was passing for me locally, I assume the locally built compiler was generating the same hash. I removed the hash lines like it was earlier, it should pass now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145820/new/

https://reviews.llvm.org/D145820