[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

Thu Mar 16 13:48:53 PDT 2023

jhuber6 accepted this revision.
jhuber6 added a comment.

LGTM, it's much simpler for now since Flang doesn't support CUDA, HIP, OpenCL, OpenMP, etc.

================
Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1
+! REQUIRES: amdgpu-registered-target
+
----------------
agozillon wrote:
> awarzynski wrote:
> > Given that you use `-###`, I think that this can be skipped (please double check).
> It does appear that it can be, at the very least I can swap in an NVIIDIA arch when I haven't configured the project to target it and it has no issues! Thank you. 
I'm not completely familiar with Flangs status on this, do we have tests in tree that perform the entire build and check `-ccc-print-bindings/phases` like we do in Clang?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145815/new/

https://reviews.llvm.org/D145815