[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 16 11:59:22 PDT 2023


asb added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:153
+  std::set<RISCVSupportedExtension, decltype(Cmp)> TempSet(Cmp);
+  for (auto E : SupportedExtensions)
+    TempSet.insert(E);
----------------
craig.topper wrote:
> Question for the community. Should we maintain SupportedExtensions in the order we want printed instead of sorting?
+1 on Kito's suggestion to print by the canonical order. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146054/new/

https://reviews.llvm.org/D146054



More information about the cfe-commits mailing list