[PATCH] D146202: [clang] Fix a UsingTemplate regression after 3e78fa860235431323aaf08c8fa922d75a7cfffa
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 16 02:50:29 PDT 2023
kadircet accepted this revision.
kadircet added a subscriber: ChuanqiXu.
kadircet added a comment.
This revision is now accepted and ready to land.
FWIW, I believe this patch does the right thing by marking the `DeducedTemplateSpecializationType` as `using`. It's explicitly introduced into the global namespace through the using decl, and even before 3e78fa860235431323aaf08c8fa922d75a7cfffa <https://reviews.llvm.org/rG3e78fa860235431323aaf08c8fa922d75a7cfffa> we weren't marking them as such.
But I am still not sure about the implications of this in the modules world. So adding @ChuanqiXu as a reviewer in case he has more insights.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146202/new/
https://reviews.llvm.org/D146202
More information about the cfe-commits
mailing list