[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

Thu Mar 16 01:01:58 PDT 2023

SixWeining added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:66
+  default:
+    return IsLA32 ? "ilp32d" : "lp64d";
+  }
----------------
Better to be `f`? (Probably most 32-bit hardwares do not support double-float? But I'm not sure about this.)

================
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41
 /// so we provide a rough mapping here.
 std::string Linux::getMultiarchTriple(const Driver &D,
                                       const llvm::Triple &TargetTriple,
----------------
xen0n wrote:
> SixWeining wrote:
> > Missing test. Perhaps add some in `clang/test/Driver/linux-ld.c` and `clang/test/Driver/linux-header-search.cpp`? Or postpone this change until loongarch is upstreamed to Debian?
> Thanks, I'll try adding the tests in the next revision.
> 
> But given [[ https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1028654 | the recent reversal of upstream dpkg support ]] (apparently due to miscommunication) it may be prudent to wait until a consensus is reached Debian-side.
[[ https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=9dfffbbae | The multiarch tuples have been upstreamed to dpkg ]].  I think we can amend the change and move on now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142688/new/

https://reviews.llvm.org/D142688