[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 15 16:09:13 PDT 2023
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/lib/CodeGen/CGExprAgg.cpp:535
CGM.getModule(), C->getType(),
- CGM.isTypeConstant(ArrayQTy, /* ExcludeCtorDtor= */ true),
+ CGM.isTypeConstant(ArrayQTy, /* ExcludeCtor= */ true,
+ /* ExcludeDtor= */ false),
----------------
I'm not sure why we're querying isTypeConstant here? The global shouldn't get written to in any case. But I guess that's a separate issue.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145369/new/
https://reviews.llvm.org/D145369
More information about the cfe-commits
mailing list