[PATCH] D145435: Choose style (file) from within code for use in IDEs

[bers via Phabricator via cfe-commits]

bersbersbers marked an inline comment as done.
bersbersbers added a comment.

> The disadvantage is that it forces everyone else who needs to review or maintain the file to deal with a style that's different from that of the directory.

"different", yes, but as explained, not necessarily incompatible.

> Are there other tools that require their special comments to be at the top of the file?

In a certain sense, yes: `clang-format` itself requires you to put `//clang-format off` comments *before* the code you want to turn it off for. So if you want to disable `clang-format` for some file, you would need to put that special comment near the top as well. So I would find it rather intuitive to have to put the style comment near the top. But I get your point, and chose not to implement any such restriction with the current revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145435/new/

https://reviews.llvm.org/D145435