[PATCH] D145074: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 15 11:32:47 PDT 2023


asb added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/riscv64-abi.c:1909
-//// NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
-// LP64F: {{.*}}
----------------
kito-cheng wrote:
> This seems removed accidentally, I saw `clang/test/CodeGen/RISCV/riscv32-abi.c` still keep.
update_cc_test_checks.py is actually correct to remove this. `void f_struct_float16_int8_insufficient_fprs` happens to have different output for lp64f vs lp64d (it has floats and doubles in its arguments).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145074/new/

https://reviews.llvm.org/D145074



More information about the cfe-commits mailing list