[PATCH] D146140: [clang] Properly parse variable template requires clause in lambda
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 15 07:55:32 PDT 2023
erichkeane added inline comments.
================
Comment at: clang/lib/Sema/SemaConcept.cpp:116
// primary-expression, and complain that it is of non-bool type.
- (NextToken.is(tok::l_paren) &&
+ (NextToken.is(tok::l_paren) && !IsLambdaRequiresClause &&
(IsTrailingRequiresClause ||
----------------
I'd like to expand on the comment above in this case. Also, since we don't decide that this is a trailing requires clause in the lambda parsing, we should probably make this more specific in this condition. I THINK we still want to do the bin-op precedence condition in this case, right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146140/new/
https://reviews.llvm.org/D146140
More information about the cfe-commits
mailing list