[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option
Jon Phillips via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 15 04:38:50 PDT 2023
jp4a50 added a comment.
In D146042#4195295 <https://reviews.llvm.org/D146042#4195295>, @owenpan wrote:
>> The previous implementation of the option involved a hack which corrupted the parenthesis state stack.
>
> Can you link the review (e.g. `Dnnnnnn`) of the previous implementation in the summary?
>
>> Specifically, this change fixes github issues #55708, #53212, #52846 and #59954.
>
> Please link the issues (e.g. https://github.com/llvm/llvm-project/issues/nnnnn).
Done! Please see updated description.
To give a little more relevant context, my team were the original authors of this feature/option (primarily for our own benefit) so we are motivated to fix it and get it right this time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146042/new/
https://reviews.llvm.org/D146042
More information about the cfe-commits
mailing list