[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 14 19:30:40 PDT 2023


owenpan added a comment.

In D141098#4192785 <https://reviews.llvm.org/D141098#4192785>, @mehdi_amini wrote:

> In D141098#4111809 <https://reviews.llvm.org/D141098#4111809>, @owenpan wrote:
>
>> Can we just fix the buildbot so that it runs git-clang-format with `--binary`? Using clang-format-15 to format a patch to clang-format-16 source still looks wrong to me.
>
> The general principle is that developers of LLVM 16 should be able to use clang-format from the previous release (that is: one where we have prebuilt binaries available) to format patches in general.
> It does not seem reasonable to me that we should need to build clang-format ourselves for the purpose of writing patches to LLVM.

Agreed, except for the clang-format source, which its `.clang-format` files are part of.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141098/new/

https://reviews.llvm.org/D141098



More information about the cfe-commits mailing list