[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

Michael Platings via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 14 15:09:24 PDT 2023


michaelplatings added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:184
+  SmallString<128> MultilibPath(SysRootDir);
+  llvm::sys::path::append(MultilibPath, MULTILIB_YAML_FILENAME);
+
----------------
phosek wrote:
> Rather than hardcoding the filename and the location, which is inflexible, could we instead provide a command line option to specify the file to use?
I'm not opposed to that in principle but I'd rather leave that as an option for a future change. At this point, for LLVM Embedded Toolchain for Arm our intent is that users will specify `--sysroot` if they want to use a separate set of multilibs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142986/new/

https://reviews.llvm.org/D142986



More information about the cfe-commits mailing list