[PATCH] D142905: [Driver] Change multilib selection algorithm

Michael Platings via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 14 14:57:56 PDT 2023


michaelplatings updated this revision to Diff 505279.
michaelplatings marked an inline comment as done.
michaelplatings added a comment.

Calculate the output for -print-multi-lib lazily.
This necessitated returning to using std::vector to store flags to avoid reordering them.
In theory the big-O time to select a multilib is larger now but in practise the number of flags is small enough that in practice this is about 2 microseconds faster per clang invocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142905/new/

https://reviews.llvm.org/D142905

Files:
  clang/include/clang/Driver/Multilib.h
  clang/include/clang/Driver/MultilibBuilder.h
  clang/lib/Driver/Multilib.cpp
  clang/lib/Driver/MultilibBuilder.cpp
  clang/lib/Driver/ToolChains/Fuchsia.cpp
  clang/unittests/Driver/MultilibBuilderTest.cpp
  clang/unittests/Driver/MultilibTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D142905.505279.patch
Type: text/x-patch
Size: 17220 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230314/dcc7ab05/attachment.bin>


More information about the cfe-commits mailing list