[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:108
   case llvm::Triple::aarch64:
     [[fallthrough]];
+  case llvm::Triple::riscv64:
----------------
Remove `[[fallthrough]]` and just list the 3 `case` consecutively.


================
Comment at: flang/test/Driver/target-cpu-features-invalid.f90:6
+! RUN: %flang_fc1 -triple aarch64-linux-gnu -target-cpu supercpu \
+! RUN: -o /dev/null -S %s 2>&1 | FileCheck %s -check-prefix=CHECK-INVALID-CPU
+
----------------
`! RUN:   -o`
For other subprojects, we prefer to indent continuation lines. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145883/new/

https://reviews.llvm.org/D145883