[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

[Erich Keane via Phabricator via cfe-commits]

erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

In D145851#4194154 <https://reviews.llvm.org/D145851#4194154>, @royjacobson wrote:

> Fix the codegen test, add a standard ref to the comment.

No worries, there is definitely somewhat of an art to writing a codegen test that won't be fragile/overspecified, I've made a few more suggestions to make it more clear/easier, else this LGTM.  Feel free to put the rest of the codegen test suggestions up for further review, but if you're comfortable with them, you may commit instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145851/new/

https://reviews.llvm.org/D145851