[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

[Roy Jacobson via Phabricator via cfe-commits]

royjacobson marked 2 inline comments as done.
royjacobson added inline comments.


================
Comment at: clang/test/CodeGen/union-non-trivial-member.cpp:30
+// CHECK-NEXT: 
+// CHECK-NEXT: define linkonce_odr dso_local void @_ZN2UnionIntC2Ev(ptr noundef nonnull align 4 dereferenceable(4) %this) unnamed_addr #1 comdat align 2 {
+// CHECK-NEXT: entry:
----------------
erichkeane wrote:
> Looking more closely, this test is a little over specific.  First, you can just do CHECK: to start each function, that way you don't have the blank lines.
> 
> In the top function, all we care about is the `call void <name>`s, so the rest of the lines can go away.  Since you're checking function's define line, you can count on ordering that way rather than check-next.
> 
> This middle function should use more wildcard/placeholders, checking fully specific names like `this` or `this.addr` is a mistake, as those aren't guaranteed to be there.  Also, all the 'align' checks are likely to make this fail in post-commit.
> 
> on the last function, we don't even care about the parameters list, so you just need the `call void <name>` part.
removed the non-essential parts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145851/new/

https://reviews.llvm.org/D145851