[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 14 08:15:28 PDT 2023


shafik added a comment.

Apologies for late review.



================
Comment at: clang/lib/Sema/SemaStmt.cpp:4405
   ASTContext &Ctx;
-  const llvm::DenseMap<CatchHandlerType, CXXCatchStmt *> &TypesToCheck;
-  const bool CheckAgainstPointer;
+  const llvm::DenseMap<QualType, CXXCatchStmt *> &TypesToCheck;
 
----------------
Can we just make `llvm::DenseMap<QualType, CXXCatchStmt *>` a typedef so we don't have the verbose type in the function parameter right below and further down.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145408/new/

https://reviews.llvm.org/D145408



More information about the cfe-commits mailing list