[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from some small nits that you can fix when landing. Thank you for your patience on this review!



================
Comment at: clang/lib/AST/DeclBase.cpp:1056
+  else if (const auto *D = dyn_cast<TypedefNameDecl>(this))
+    Ty = D->getUnderlyingType();
+  else
----------------
erichkeane wrote:
> probably want to canonicalize here (and above).  Else typedefs-to-typedefs/etc might getcha.
Yeah, I'd do that below on the return, as in: `return Ty.getCanonicalType()->isFunctionPointerType();`


================
Comment at: clang/test/SemaCXX/wasm-funcref.cpp:14
+}
\ No newline at end of file

----------------
Please add a newline to the end of the file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128440/new/

https://reviews.llvm.org/D128440