[PATCH] D146023: [AMDGPU] Remove Code Object V2

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

Is clover still relying on the cov2 support?



================
Comment at: clang/include/clang/Basic/TargetOptions.h:85
     COV_None,
-    COV_2 = 200,
     COV_3 = 300,
----------------
I wouldn't remove the enum field, just add a comment that emission is unsupported or something


================
Comment at: llvm/test/MC/AMDGPU/hsa-gfx10.s:3
-// RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=gfx1010 --amdhsa-code-object-version=2 -mattr=-wavefrontsize32,+wavefrontsize64 -show-encoding %s | llvm-readobj -S --sd --syms - | FileCheck %s --check-prefix=ELF
-
-// ELF: Section {
----------------
I thought we were still going to be able to read old objects 


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5437-5440
+    // FIXME: Metadata Verifier doesn't work with AMDPAL MD.
+    //  This is a ugly workaround to avoid the verifier.
+    if (MsgPackString.find("amdpal.") == StringRef::npos) {
+      AMDGPU::HSAMD::V3::MetadataVerifier Verifier(true);
----------------
This looks like a separate change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146023/new/

https://reviews.llvm.org/D146023