[PATCH] D146023: [AMDGPU] Remove Code Object V2

[Konstantin Zhuravlyov via Phabricator via cfe-commits]

kzhuravl added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:1379
 .. warning::
-  Code object V2 is not the default code object version emitted by
-  this version of LLVM.
+  Code object V2 emission is no longer supported by this version of LLVM.
 
----------------
emission->generation?


================
Comment at: llvm/docs/AMDGPUUsage.rst:2647
 .. warning::
-  Code object V2 is not the default code object version emitted by this version
-  of LLVM.
+  Code object V2 emission is no longer supported by this version of LLVM.
 
----------------
emission->generation?


================
Comment at: llvm/docs/AMDGPUUsage.rst:14597
 .. warning::
-  Code object V2 is not the default code object version emitted by
-  this version of LLVM.
+  Code object V2 emission is no longer supported by this version of LLVM.
 
----------------
ditto


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp:749-750
-    case AMDGPU::AMDHSA_COV2:
-      // Code object V2 only supported specific processors and had fixed
-      // settings for the XNACK.
-      if (Processor == "gfx600") {
----------------
Nice to see this finally go


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146023/new/

https://reviews.llvm.org/D146023