[PATCH] D146023: [AMDGPU] Remove Code Object V2Code Object V2 has been deprecated for more than a year now. We can safely remove it from LLVM.

Tue Mar 14 01:42:05 PDT 2023

Pierre-vh created this revision.
Herald added subscribers: kosarev, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, emaste, arsenm, qcolombet, MatzeB.
Herald added a reviewer: jhenderson.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead, sstefan1, MaskRay, wdng.
Herald added a reviewer: jdoerfert.
Herald added projects: clang, LLVM.

- [clang] Remove support for the `-mcode-object-version=2` option.
- [lld] Remove/refactor tests that were still using COV2
- [llvm] Update AMDGPUUsage.rst
  - Code Object V2 docs are left for informational purposes because those code objects may still be supported by the runtime/loaders for a while.
- [AMDGPU] Remove COV2 emission capabilities.
- [AMDGPU] Remove `MetadataStreamerYamlV2` which was only used by COV2
- [AMDGPU] Update all tests that were still using COV2
  - They are either deleted or ported directly to code object v4 (as v3 is also planned to be removed soon).
- [llvm-readobj] Fix reading of AMDPAL metadata
  - The verifier was always ran but only supports AMDHSA MD. This was causing metadata reading errors on AMDPAL tests that were ported to V4 in this patch.

Depends on D145671 <https://reviews.llvm.org/D145671>

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146023

Files:
  clang/include/clang/Basic/TargetOptions.h
  clang/include/clang/Driver/Options.td
  clang/lib/Driver/ToolChains/CommonArgs.cpp
  clang/test/CodeGenCUDA/amdgpu-code-object-version.cu
  clang/test/Driver/hip-code-object-version.hip
  lld/test/ELF/Inputs/amdgpu-kernel-0.s
  lld/test/ELF/Inputs/amdgpu-kernel-1.s
  lld/test/ELF/amdgpu-abi-version-err.s
  lld/test/ELF/amdgpu-elf-flags-err.s
  lld/test/ELF/amdgpu-elf-flags.s
  lld/test/ELF/amdgpu-kernels.s
  llvm/docs/AMDGPUUsage.rst
  llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp
  llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.h
  llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.dispatch.id.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.dispatch.ptr.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.kernarg.segment.ptr.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.queue.ptr.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.workgroup.id.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.workitem.id.ll
  llvm/test/CodeGen/AMDGPU/addrspacecast.ll
  llvm/test/CodeGen/AMDGPU/amdgpu.private-memory.ll
  llvm/test/CodeGen/AMDGPU/attr-amdgpu-flat-work-group-size.ll
  llvm/test/CodeGen/AMDGPU/call-graph-register-usage.ll
  llvm/test/CodeGen/AMDGPU/callee-special-input-vgprs.ll
  llvm/test/CodeGen/AMDGPU/control-flow-fastregalloc.ll
  llvm/test/CodeGen/AMDGPU/elf-notes.ll
  llvm/test/CodeGen/AMDGPU/flat-for-global-subtarget-feature.ll
  llvm/test/CodeGen/AMDGPU/flat-scratch-reg.ll
  llvm/test/CodeGen/AMDGPU/gfx902-without-xnack.ll
  llvm/test/CodeGen/AMDGPU/hsa-default-device.ll
  llvm/test/CodeGen/AMDGPU/hsa-fp-mode.ll
  llvm/test/CodeGen/AMDGPU/hsa-func.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-deduce-ro-arg.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-enqueue-kernel.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-hidden-args.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-images.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-invalid-ocl-version-1.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-invalid-ocl-version-2-v3.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-invalid-ocl-version-2.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-invalid-ocl-version-3.ll
  llvm/test/CodeGen/AMDGPU/hsa-metadata-kernel-code-props.ll
  llvm/test/CodeGen/AMDGPU/hsa-note-no-func.ll
  llvm/test/CodeGen/AMDGPU/hsa.ll
  llvm/test/CodeGen/AMDGPU/indirect-call.ll
  llvm/test/CodeGen/AMDGPU/kernel-argument-dag-lowering.ll
  llvm/test/CodeGen/AMDGPU/lds-alignment.ll
  llvm/test/CodeGen/AMDGPU/lds-size.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.dispatch.id.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.dispatch.ptr.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.implicitarg.ptr.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.kernarg.segment.ptr.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.queue.ptr.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.workgroup.id.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.workitem.id.ll
  llvm/test/CodeGen/AMDGPU/no-hsa-graphics-shaders.ll
  llvm/test/CodeGen/AMDGPU/nop-data.ll
  llvm/test/CodeGen/AMDGPU/private-element-size.ll
  llvm/test/CodeGen/AMDGPU/promote-alloca-no-opts.ll
  llvm/test/CodeGen/AMDGPU/promote-alloca-padding-size-estimate.ll
  llvm/test/CodeGen/AMDGPU/tid-code-object-v2-backwards-compatibility.ll
  llvm/test/CodeGen/AMDGPU/trap-abis.ll
  llvm/test/CodeGen/AMDGPU/trap.ll
  llvm/test/MC/AMDGPU/hsa-exp.s
  llvm/test/MC/AMDGPU/hsa-gfx10.s
  llvm/test/MC/AMDGPU/hsa-metadata-kernel-args.s
  llvm/test/MC/AMDGPU/hsa-metadata-kernel-attrs.s
  llvm/test/MC/AMDGPU/hsa-metadata-kernel-code-props.s
  llvm/test/MC/AMDGPU/hsa-metadata-kernel-debug-props.s
  llvm/test/MC/AMDGPU/hsa-metadata-unknown-key.s
  llvm/test/MC/AMDGPU/hsa-text.s
  llvm/test/MC/AMDGPU/hsa-wave-size.s
  llvm/test/MC/AMDGPU/hsa.s
  llvm/test/MC/AMDGPU/hsa_code_object_isa_args.s
  llvm/test/MC/AMDGPU/isa-version-hsa.s
  llvm/test/MC/AMDGPU/isa-version-pal.s
  llvm/test/MC/AMDGPU/isa-version-unk.s
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146023.504984.patch
Type: text/x-patch
Size: 428262 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230314/4c8f9147/attachment-0001.bin>