[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

Younan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 13 23:12:56 PDT 2023


zyounan updated this revision to Diff 504947.
zyounan marked 3 inline comments as done.
zyounan added a comment.

Address the comments. Revise parameters of `getSignature` to avoid passing CCR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145319/new/

https://reviews.llvm.org/D145319

Files:
  clang-tools-extra/clangd/CodeComplete.cpp
  clang-tools-extra/clangd/CodeCompletionStrings.cpp
  clang-tools-extra/clangd/CodeCompletionStrings.h
  clang-tools-extra/clangd/index/SymbolCollector.cpp
  clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
  clang-tools-extra/clangd/unittests/CodeCompletionStringsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145319.504947.patch
Type: text/x-patch
Size: 7919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230314/ecdb60e8/attachment.bin>


More information about the cfe-commits mailing list