[PATCH] D145852: [Clang][AST] Fix __has_unique_object_representations computation for unnamed bitfields.

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/test/SemaCXX/type-traits.cpp:2886-2889
+struct UnnamedEmptyBitfield {
+  int named;
+  int : 0;
+};
----------------
aaron.ballman wrote:
> I think there's one more test to add:
> ```
> struct UnnamedEmptyBitfieldSplit {
>   short named;
>   int : 0;
>   short also_named;
> };
> static_assert(sizeof(UnnamedEmptyBitfieldSplit) != (sizeof(short) * 2));
> static_assert(!has_unique_object_representations<UnnamedEmptyBitfieldSplit>::value, "Bitfield padding");
> ```
Do we also want to check packed structs as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145852/new/

https://reviews.llvm.org/D145852