[PATCH] D142905: [Driver] Change multilib selection algorithm

Michael Platings via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 13 11:31:25 PDT 2023


michaelplatings marked an inline comment as done.
michaelplatings added inline comments.


================
Comment at: clang/include/clang/Driver/Multilib.h:67
+  /// a subset of the flags derived from the Clang command line options.
+  const flag_set &flags() const { return Flags; }
 
----------------
peter.smith wrote:
> Would be good to reference the Multilib Design document's definition and examples of (what will be renamed in D145567 to tags).
> 
> This may require moving the design doc down the stack, probably not necessary if everything is committed at once.
I've changed D143587 to update the comment to reference the docs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142905/new/

https://reviews.llvm.org/D142905



More information about the cfe-commits mailing list