[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

Mon Mar 13 10:08:55 PDT 2023

erichkeane added a comment.

In D145851#4189916 <https://reviews.llvm.org/D145851#4189916>, @royjacobson wrote:

> In D145851#4189158 <https://reviews.llvm.org/D145851#4189158>, @erichkeane wrote:
>
>> Generally looks good to me.  Do we do anything special if there are multiple initializers?  Also, can we have a codegen test that validates that we actually construct it correctly (and perhaps a constexpr test for the same!)?
>
> Added constexpr + codegen tests.
>
> If we have multiple initializers it's an error that's already diagnosed, I assume the error recovery just drops any initializer after the first.

Got it, thanks!  LGTM!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145851/new/

https://reviews.llvm.org/D145851