[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

This needs a release note.  Also, the patch message doesn't do a good job explaining what is going on here.

Also, I'm not sure this is the right answer.  The purpose of `CorrectDelayedTyposInExpr` is, in part, to make sure we emit the diagnostics of all child expressions.  It seems this patch would make us miss other issues in the `Foo<T>(Unknown)` if they were to exist, which will make our compiler experience worse, particularly if it is the reason it seems that we don't see an expansion here.   I cannot debug right now, but I suspect the fix to this issue is really in `TransformTypoExpr`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145892/new/

https://reviews.llvm.org/D145892