[PATCH] D145921: [clangd] Add missing unittests to build graph

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 13 04:53:37 PDT 2023


kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/tweaks/SpecialMembersTests.cpp:21
   EXPECT_UNAVAILABLE("struct S { ^ };");
-  EXPECT_UNAVAILABLE("union ^U {};");
+  EXPECT_AVAILABLE("union ^U {};");
   EXPECT_AVAILABLE("struct ^S { S(const S&); S(S&&); };");
----------------
hokein wrote:
> the old behavior (UNAVAILABLE) seems more reasonable to me, I have a fix in https://reviews.llvm.org/D145922.
i don't see much reason for disabling on unions, but don't have a strong preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145921/new/

https://reviews.llvm.org/D145921



More information about the cfe-commits mailing list