[PATCH] D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores

Mon Mar 13 03:26:41 PDT 2023

dang added inline comments.

================
Comment at: clang/test/ExtractAPI/ignored-symbols-multifile.c:34
+//--- ignores-list1
+IGNORED_FILE1_1
+IGNORED_FILE1_2
----------------
This test doesn't check the symbol name sorting behavior across multiple files, which is crucial `APIIgnoresList::shouldIgnore(StringRef SymbolName)` because it uses binary search to find the symbol in the list. Would you be able to shuffle the order of the macros so that they aren't pre-sorted?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145869/new/

https://reviews.llvm.org/D145869