[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

Takuya Shimizu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 12 20:45:32 PDT 2023


hazohelet updated this revision to Diff 504501.
hazohelet added a comment.

Address comments from @shafik

- Pass bool flag `UnreachableFallThroughDiagIsEnabled` instead of `DiagnosticsEngine`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145842/new/

https://reviews.llvm.org/D145842

Files:
  clang/include/clang/Analysis/Analyses/ReachableCode.h
  clang/lib/Analysis/ReachableCode.cpp
  clang/lib/Sema/AnalysisBasedWarnings.cpp
  clang/test/Sema/warn-unreachable-fallthrough.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145842.504501.patch
Type: text/x-patch
Size: 5987 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230313/e79d3c5d/attachment.bin>


More information about the cfe-commits mailing list