[clang-tools-extra] c4918cb - [clang-tidy] Provide default template arguments in <string>

[Piotr Zegar via cfe-commits]

Author: Mike Crowe
Date: 2023-03-12T13:32:45Z
New Revision: c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec

URL: https://github.com/llvm/llvm-project/commit/c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec
DIFF: https://github.com/llvm/llvm-project/commit/c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec.diff

LOG: [clang-tidy] Provide default template arguments in <string>

Simplify the use of the basic_string and basic_string_view types by
providing default template arguments.

Depends on D145311

Reviewed By: PiotrZSL

Differential Revision: https://reviews.llvm.org/D145724

Added: 
    

Modified: 
    clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string b/clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string
index 91ae2af4d132..e9d31b929c6c 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string
+++ b/clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string
@@ -12,7 +12,7 @@ template <typename T>
 class allocator {};
 template <typename T>
 class char_traits {};
-template <typename C, typename T, typename A>
+template <typename C, typename T = char_traits<C>, typename A = allocator<C>>
 struct basic_string {
   typedef size_t size_type;
   typedef basic_string<C, T, A> _Type;
@@ -55,19 +55,19 @@ struct basic_string {
   _Type& operator=(const C* s);
 };
 
-typedef basic_string<char, std::char_traits<char>, std::allocator<char>> string;
-typedef basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t>> wstring;
-typedef basic_string<char16, std::char_traits<char16>, std::allocator<char16>> u16string;
-typedef basic_string<char32, std::char_traits<char32>, std::allocator<char32>> u32string;
+typedef basic_string<char> string;
+typedef basic_string<wchar_t> wstring;
+typedef basic_string<char16> u16string;
+typedef basic_string<char32> u32string;
 
-template <typename C, typename T>
+template <typename C, typename T = char_traits<C>>
 struct basic_string_view {
   basic_string_view(const C* s);
 };
-typedef basic_string_view<char, std::char_traits<char>> string_view;
-typedef basic_string_view<wchar_t, std::char_traits<wchar_t>> wstring_view;
-typedef basic_string_view<char16, std::char_traits<char16>> u16string_view;
-typedef basic_string_view<char32, std::char_traits<char32>> u32string_view;
+typedef basic_string_view<char> string_view;
+typedef basic_string_view<wchar_t> wstring_view;
+typedef basic_string_view<char16> u16string_view;
+typedef basic_string_view<char32> u32string_view;
 
 std::string operator+(const std::string&, const std::string&);
 std::string operator+(const std::string&, const char*);