[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 11 10:06:20 PST 2023


dblaikie added a comment.

Yeah, can't say this had occurred to me - but totally makes sense/reckon it's OK. Any reason to limit this to lldb? I'd expect it'd probably "Just Work(tm)" on any DWARF consumer?

it doesn't hit any recursion issues? (I guess maybe skirts it due to the existing recursion handling in the decl/def structure type stuff - so it creates a declaration for the type, then creates the typedef, which can find that existing declaration, then return the typedef from the create type query?)

I guess it means that references to the type even for like, the type of the "this" parameter - would refer to the typedef? That's /probably/ OK if a bit surprising to some people/consumers sometimes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145803/new/

https://reviews.llvm.org/D145803



More information about the cfe-commits mailing list