[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 11 07:07:42 PST 2023


awarzynski added a comment.

I'd move these tests to flang/test/Driver/supported-suffices. That would help documenting what these tests actual check for. Also, one could be tempted to test for other suffices and then it would be nice to keep them in one place. Ta!



================
Comment at: flang/test/Driver/f03-suffix.f03:1
+! RUN: %flang -### -flang-experimental-exec %s 2>&1 | FileCheck %s
+
----------------
You can safely drop `-flang-experimental-exec` here.


================
Comment at: flang/test/Driver/f03-suffix.f03:4
+! CHECK: "{{.*}}flang-new" "-fc1" {{.*}} "/tmp/{{.*}}.o"
+! CHECK: "{{.*}}ld" {{.*}} "/tmp/{{.*}}.o"
+program f03
----------------
The linker invocation is unrelated to this change. Also, it will very likely look differently on other operating systems. Best to skip it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145845/new/

https://reviews.llvm.org/D145845



More information about the cfe-commits mailing list