[clang] 326c135 - [NFC] [CMake] Cleanup clang tool dependencies

Chris Bieneman via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 10 08:56:29 PST 2023


Author: Chris Bieneman
Date: 2023-03-10T10:56:07-06:00
New Revision: 326c13531af32df8361cb4c98d2cc1355b0f8c48

URL: https://github.com/llvm/llvm-project/commit/326c13531af32df8361cb4c98d2cc1355b0f8c48
DIFF: https://github.com/llvm/llvm-project/commit/326c13531af32df8361cb4c98d2cc1355b0f8c48.diff

LOG: [NFC] [CMake] Cleanup clang tool dependencies

None of these tools need to depend on clang to build, instead the test
target should depend on them.

This prevents rebuilding/linking these tools when building the `clang`
target directly.

Added: 
    

Modified: 
    clang/test/CMakeLists.txt
    clang/tools/clang-linker-wrapper/CMakeLists.txt
    clang/tools/clang-offload-bundler/CMakeLists.txt
    clang/tools/clang-offload-packager/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/test/CMakeLists.txt b/clang/test/CMakeLists.txt
index 1d6377b5f2d80..7f37bae7ed954 100644
--- a/clang/test/CMakeLists.txt
+++ b/clang/test/CMakeLists.txt
@@ -71,6 +71,7 @@ list(APPEND CLANG_TEST_DEPS
   clang-refactor
   clang-
diff 
   clang-scan-deps
+  clang-linker-wrapper
   diagtool
   hmaptool
   )

diff  --git a/clang/tools/clang-linker-wrapper/CMakeLists.txt b/clang/tools/clang-linker-wrapper/CMakeLists.txt
index 8ddfcc6c59d35..b5f1c0dd0e7d3 100644
--- a/clang/tools/clang-linker-wrapper/CMakeLists.txt
+++ b/clang/tools/clang-linker-wrapper/CMakeLists.txt
@@ -39,8 +39,6 @@ set(CLANG_LINKER_WRAPPER_LIB_DEPS
   clangBasic
   )
 
-add_dependencies(clang clang-linker-wrapper)
-
 target_link_libraries(clang-linker-wrapper
   PRIVATE
   ${CLANG_LINKER_WRAPPER_LIB_DEPS}

diff  --git a/clang/tools/clang-offload-bundler/CMakeLists.txt b/clang/tools/clang-offload-bundler/CMakeLists.txt
index 7bc22f1479d72..dabd82382cdf0 100644
--- a/clang/tools/clang-offload-bundler/CMakeLists.txt
+++ b/clang/tools/clang-offload-bundler/CMakeLists.txt
@@ -16,8 +16,6 @@ set(CLANG_OFFLOAD_BUNDLER_LIB_DEPS
   clangDriver
   )
 
-add_dependencies(clang clang-offload-bundler)
-
 clang_target_link_libraries(clang-offload-bundler
   PRIVATE
   ${CLANG_OFFLOAD_BUNDLER_LIB_DEPS}

diff  --git a/clang/tools/clang-offload-packager/CMakeLists.txt b/clang/tools/clang-offload-packager/CMakeLists.txt
index accc9486f46ab..1c29e376452c1 100644
--- a/clang/tools/clang-offload-packager/CMakeLists.txt
+++ b/clang/tools/clang-offload-packager/CMakeLists.txt
@@ -11,8 +11,6 @@ add_clang_tool(clang-offload-packager
   ${tablegen_deps}
   )
 
-add_dependencies(clang clang-offload-packager)
-
 clang_target_link_libraries(clang-offload-packager
   PRIVATE
   clangBasic


        


More information about the cfe-commits mailing list