[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 10 06:19:44 PST 2023


erichkeane added a comment.

Looks like this doesn't compile pre-commit, though no idea if that is a patch-stack issue.  Other than test, patch looks fine.



================
Comment at: clang/test/Frontend/plugin-attribute-pp.cpp:1
+// RUN: split-file %s %t
+// RUN: %clang -fplugin=%llvmshlibdir/Attribute%pluginext -E %t/has_attr.cpp | FileCheck %t/has_attr.cpp
----------------
This split-file thing is weird, don't do that.  create 2 tests instead, OR Just use -x c and -x c++ to change languages (you can use a separate macro to get __has_c and __has_cpp_attribute right).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144405/new/

https://reviews.llvm.org/D144405



More information about the cfe-commits mailing list