[PATCH] D145776: [clangd] Remove the classical clangd-own unsued-include implementation.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 10 02:33:01 PST 2023


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

i'd still merge this with the previous patch, as all of this is dead code after config option deletion. so it'd be better to just revert a single patch if we want to restore the old behavior, rather than two.



================
Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:720
 
 TEST(IncludeCleaner, RecursiveInclusion) {
   TestTU TU;
----------------
i don't think this test is meaningful for our current usage of the include-cleaner library, feel free to drop it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145776/new/

https://reviews.llvm.org/D145776



More information about the cfe-commits mailing list