[PATCH] D118493: Set rpath on openmp executables

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 13:41:34 PST 2023


MaskRay added a comment.

In D118493#4182583 <https://reviews.llvm.org/D118493#4182583>, @JonChesterfield wrote:

> Duplicating a comment from the commit thread so it's easier for me to find later.
>
> You've applied this to the release branches going back as far as 14. It's a user facing breaking change. As in people who have a working openmp toolchain and update to the point release which looks like a semantic versioning thing indicating minor bugfixes will experience immediate cessation of function. I consider that very poor user experience and do not agree with the scope of breakage.

555b572e3f407ac48b5f30fc06760cc4d0549977 <https://reviews.llvm.org/rG555b572e3f407ac48b5f30fc06760cc4d0549977> is only in the main branch, not in `release/14.x`, `release/15.x`, or `releast/16.x`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118493/new/

https://reviews.llvm.org/D118493



More information about the cfe-commits mailing list