[PATCH] D145312: [clang-tidy] Make readability-string-compare check use <string> header

Mike Crowe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 12:51:24 PST 2023


mikecrowe marked an inline comment as done.
mikecrowe added inline comments.
Herald added a subscriber: PiotrZSL.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/string-compare.cpp:4-8
-template <typename T>
-class allocator {};
-template <typename T>
-class char_traits {};
-template <typename C, typename T = std::char_traits<C>, typename A = std::allocator<C>>
----------------
carlosgalvezp wrote:
> Would it make sense to add these to the new header?
Done in https://reviews.llvm.org/D145724 .


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145312/new/

https://reviews.llvm.org/D145312



More information about the cfe-commits mailing list