[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

Snehasish Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 11:38:33 PST 2023


snehasish marked an inline comment as done.
snehasish added a comment.

In D145644#4182239 <https://reviews.llvm.org/D145644#4182239>, @tejohnson wrote:

> Generally lgtm, but why did the raw profiles change size from what is currently committed?

The reduction in size of the raw profiles is due to D145528 <https://reviews.llvm.org/D145528> where we moved the initialization flags. The older raw profiles include e.g. 4 entries for the basic test case including calls to malloc from `Symbolizer::LateInitialize`. These two entries were pruned by the filtering logic in RawMemProfReader but contribute to the original raw file size. After D145528 <https://reviews.llvm.org/D145528> we only have two entries in the generated raw profile. Verified by making a local change to disable filtering and ran `llvm-profdata show --memory` on the older profiles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145644/new/

https://reviews.llvm.org/D145644



More information about the cfe-commits mailing list