[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit

Julian Lettner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 11:32:20 PST 2023


yln created this revision.
Herald added subscribers: ormris, hiraditya.
Herald added a project: All.
yln requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

Remove the `-lower-global-dtors-via-cxa-atexit` escape hatch introduced
in D121736 <https://reviews.llvm.org/D121736> [1], which switched the default lowering of global
destructors on MachO to use `__cxa_atexit()` to avoid emitting
deprecated `__mod_term_func` sections.

I added this flag as an escape hatch in case the switch causes any
problems.  We didn't discover any problems so now we can remove it.

[1] https://reviews.llvm.org/D121736

rdar://90277838


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145715

Files:
  clang/lib/CodeGen/BackendUtil.cpp
  llvm/include/llvm/CodeGen/CommandFlags.h
  llvm/include/llvm/Target/TargetOptions.h
  llvm/lib/CodeGen/CommandFlags.cpp
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/CodeGen/TargetPassConfig.cpp
  llvm/test/CodeGen/ARM/ctors_dtors.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145715.503862.patch
Type: text/x-patch
Size: 5787 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230309/6215e0a3/attachment.bin>


More information about the cfe-commits mailing list