[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

Thu Mar 9 11:14:22 PST 2023

aaron.ballman added a subscriber: tstellar.
aaron.ballman added a comment.

Thank you for working on this! Because this is fixing an ABI break, if we can land this in time for the release candidate I think we should try to add this to 16.0 to limit damage. CC @tstellar for his opinion.

This doesn't seem to fully revert bbf0d1932a3c1be970ed8a580e51edf571b80fd5 <https://reviews.llvm.org/rGbbf0d1932a3c1be970ed8a580e51edf571b80fd5>; that commit changed `clang/lib/Sema/Sema.cpp` but this commit does not back those changes out. Is that intentional?

================
Comment at: clang/test/Preprocessor/flt_eval_macro.cpp:66-68
   // CHECK: #define Name "One"
   // CHECK-MINUS-ONE: #define Name "MinusOne"
   // EXT: #define Name "Three"
----------------
This line is no longer needed because it will never be checked.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145704/new/

https://reviews.llvm.org/D145704