[PATCH] D145644: [memprof] Add scripts to automate testdata regeneration.

Snehasish Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 10:53:29 PST 2023


snehasish added inline comments.


================
Comment at: llvm/test/Transforms/PGOProfile/Inputs/update_memprof_inputs.sh:63
+  delete[] f;
+
+  // Loop ensures the two calls to recurse have stack contexts that only differ
----------------
@tejohnson Turns out the LLVM IR matching issue was due to a difference in the code from which the IR was generated. The one in the comments has a line offset of 30 from `main` to the callsite of `recurse` whereas the memprof.ll IR expects a line offset of 31. Perhaps a comment or blank line was omitted? I added a blank line here and added a comment in the update script too. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145644/new/

https://reviews.llvm.org/D145644



More information about the cfe-commits mailing list