[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In D145591#4182016 <https://reviews.llvm.org/D145591#4182016>, @tra wrote:

> It sounds like what we want is to make `-x hip` and `-fopenmp` mutually exclusive, with a hard error when both are used. If you look at the problem as "-fopenmp completely breaks HIP compilation", a warning is a bit too weak of a measure, IMO.
>
> We can restate it all as "mixing offloading modes is not supported" and generalize it to both CUDA and HIP.

-x hip and -fopenmp has been a valid combination. -fopenmp with -x hip allows non-offloading OpenMP directives in host code in HIP. It just ignores the offloading directives.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145591/new/

https://reviews.llvm.org/D145591