[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

Zahira Ammarguellat via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 9 10:24:54 PST 2023


zahiraam created this revision.
zahiraam added reviewers: andrew.w.kaylor, aaron.ballman.
Herald added a subscriber: pengfei.
Herald added a project: All.
zahiraam requested review of this revision.
Herald added a project: clang.

Setting __FLT_EVAL_METHOD__ to -1 with fast-math will set __GLIBC_FLT_EVAL_METHOD to 2 and long double ends up being used for
float_t and double_t. This creates some ABI breakage with various C libraries.

See details here: https://github.com/llvm/llvm-project/issues/60781

This reverts commit bbf0d1932a3c1be970ed8a580e51edf571b80fd5 <https://reviews.llvm.org/rGbbf0d1932a3c1be970ed8a580e51edf571b80fd5>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145704

Files:
  clang/include/clang/Lex/Preprocessor.h
  clang/lib/Lex/PPMacroExpansion.cpp
  clang/lib/Lex/Preprocessor.cpp
  clang/lib/Sema/SemaAttr.cpp
  clang/test/CodeGen/X86/fexcess-precision.c
  clang/test/CodeGen/eval-method-fast-math.cpp
  clang/test/Preprocessor/flt_eval_macro.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145704.503821.patch
Type: text/x-patch
Size: 10519 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230309/ece274a7/attachment-0001.bin>


More information about the cfe-commits mailing list